Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.12.z] fixes in api role helper functions #13868

Merged
merged 2 commits into from
Mar 19, 2024
Merged

[6.12.z] fixes in api role helper functions #13868

merged 2 commits into from
Mar 19, 2024

Conversation

Satellite-QE
Copy link
Collaborator

Cherrypick of PR: #13849

Problem Statement

#12989 updated the create_domain and create_simple_user helpers to use target_sat but didn't update all the callers accordingly

Solution

this pr

@Satellite-QE Satellite-QE added 6.12.z Introduced in or relating directly to Satellite 6.12 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches labels Jan 23, 2024
@Satellite-QE
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/api/test_role.py -k test_negative_access_entities_from_org_admin

@Satellite-QE Satellite-QE added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Jan 23, 2024
@pondrejk
Copy link
Contributor

trigger: test-robottelo
pytest: tests/foreman/api/test_role.py -k test_negative_access_entities_from_org_admin

1 similar comment
@pondrejk
Copy link
Contributor

trigger: test-robottelo
pytest: tests/foreman/api/test_role.py -k test_negative_access_entities_from_org_admin

@Gauravtalreja1
Copy link
Collaborator

Looking at the PRT results, you'll need to pull this changes into 6.12.z as well #13465 for this module

@Gauravtalreja1
Copy link
Collaborator

@pondrejk @vijaysawant Could you update this PR after fixing the mentioned cherrypick?

@pondrejk
fixes in api role helper functions (#13849)
047002a 
paramter order in api role helper functions

(cherry picked from commit b588165)
@pondrejk pondrejk force-pushed the cherry-pick-6.12.z-b588165f567a830ef7175b08128ce34295e4dfd2 branch from 5a0c2fd to 047002a Compare March 19, 2024 14:35
@pondrejk
Copy link
Contributor

trigger: test-robottelo
pytest: tests/foreman/api/test_role.py -k test_negative_access_entities_from_org_admin

@Satellite-QE
Copy link
Collaborator Author

PRT Result

Build Number: 6128
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_role.py -k test_negative_access_entities_from_org_admin --external-logging
Test Result : ========== 1 failed, 49 deselected, 8 warnings in 1262.21s (0:21:02) ===========

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Mar 19, 2024
@pondrejk
Copy link
Contributor

trigger: test-robottelo
pytest: tests/foreman/api/test_role.py -k test_negative_access_entities_from_org_admin

@Satellite-QE Satellite-QE removed the PRT-Failed Indicates that latest PRT run is failed for the PR label Mar 19, 2024
@Satellite-QE Satellite-QE merged commit 6fff88a into 6.12.z Mar 19, 2024
9 checks passed
@Satellite-QE Satellite-QE deleted the cherry-pick-6.12.z-b588165f567a830ef7175b08128ce34295e4dfd2 branch March 19, 2024 16:25
@Satellite-QE
Copy link
Collaborator Author

PRT Result

Build Number: 6132
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_role.py -k test_negative_access_entities_from_org_admin --external-logging
Test Result : ========== 1 passed, 49 deselected, 8 warnings in 1385.61s (0:23:05) ===========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Mar 19, 2024
@Gauravtalreja1
Copy link
Collaborator

Thanks @pondrejk :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pondrejk pondrejk

Labels
6.12.z Introduced in or relating directly to Satellite 6.12 Auto_Cherry_Picked Automatically cherrypicked PR using GHA AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Satellite-QE @pondrejk @Gauravtalreja1 @vijaysawant